Skip to content

Added support for any data type of schedule and fixed subnet mask validation#2022

Merged
samson0v merged 5 commits intothingsboard:masterfrom
majuss:master
Dec 1, 2025
Merged

Added support for any data type of schedule and fixed subnet mask validation#2022
samson0v merged 5 commits intothingsboard:masterfrom
majuss:master

Conversation

@majuss
Copy link
Contributor

@majuss majuss commented Nov 17, 2025

Now you can write any type of datapoint in a schedule. Before it was limited to decimals.

Fixed a bug in subnetmask detection for BACnet

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2025

CLA assistant check
All committers have signed the CLA.

@samson0v samson0v added the bug label Nov 18, 2025
@samson0v samson0v changed the title [BACnet] Allow any datatype in bacnet schedule; fix subnetmask Added support for any data type of schedule and fixed subnet mask validation Nov 18, 2025
@samson0v
Copy link
Contributor

@majuss, thanks for your contribution!
Please resolve the comments above, and I will merge your PR.

@github-actions github-actions bot removed the bug label Nov 18, 2025
@majuss
Copy link
Contributor Author

majuss commented Nov 18, 2025

Please don't merge just yet I need to optimise the subnet detection. Also default net 24 is maybe not helpful. 32 is in my opinion the "normal" one.

@samson0v
Copy link
Contributor

@majuss got it, I will wait for your message.

@majuss
Copy link
Contributor Author

majuss commented Nov 18, 2025

Can you please have a look at my comment: ccf4197
@samson0v

@samson0v
Copy link
Contributor

@majuss, do you need any help?

@majuss
Copy link
Contributor Author

majuss commented Nov 20, 2025

It would be nice if you could take on this change: ccf4197

@samson0v samson0v added this to the 3.8.1 milestone Nov 25, 2025
@majuss
Copy link
Contributor Author

majuss commented Nov 26, 2025

@samson0v do you have a timeline for this :)?

@samson0v
Copy link
Contributor

samson0v commented Nov 26, 2025

@majuss, we were working on the release today. I remember about your request)
I will fix that part as soon as possible. And your feature will be in the Gateway release v.3.8.1.

@majuss
Copy link
Contributor Author

majuss commented Nov 28, 2025

@samson0v I rewrote the find_values function to list only unique values and it works with unhashable data.

@samson0v samson0v linked an issue Dec 1, 2025 that may be closed by this pull request
@samson0v samson0v merged commit 7e27e72 into thingsboard:master Dec 1, 2025
4 checks passed
@samson0v
Copy link
Contributor

samson0v commented Dec 1, 2025

@majuss, thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] BACnet Subnet masks other than /24 (255.255.255.0)

4 participants