fix: ensure a single h1 per page#442
Merged
Merged
Conversation
- device-library detail: card title h1 -> p (Starlight renders page h1) - careers: hero title h2 -> h1 (page had no h1) - installations: only ThingsBoard Cloud tab keeps h1, other product tabs -> h2 - asset-management: section headings h1 -> h2 - ce-vs-pe-diff: site-name logo h1 -> div - blog: demote/remove stray body-level h1 in two posts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes pages that rendered multiple
<h1>elements (a11y / SEO issue). Each affected page now has exactly one<h1>.Changes
DeviceInfoCard.astro): card title<h1>→<p>— Starlight already renders the page<h1>. Look unchanged (styled via.dl-info-card__title).JobsSection.astro): page had no<h1>; hero title<h2>→<h1>, selector extended so the look is identical.ProductSection.astro,installations/index.astro): all product tabs are in the DOM (inactive onesdisplay:none), each emitting an<h1>. Only the default ThingsBoard Cloud tab keeps<h1>; other product titles →<h2>(styled to match).asset-management/index.astro): three section headings<h1>→<h2>(natural h2 size).ce-vs-pe-diff/index.astro): site-name/logo<h1>→<div>(styled via.site-name).#heading on top of the template title —tbmq-1-3-0…#→##;how-an-iot-based-liquid-tank…removed the duplicated title line.