return block data when deleting it #175
Open
+97
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Enhanced
DeleteBlockData
to return deleted block data, enabling better handling of reorgs.What changed?
Modified the
DeleteBlockData
method in the storage interface to return the deleted block data:IMainStorage
interface to return([]common.BlockData, error)
ClickHouseConnector
to collect and return deleted datadeleteBlocks
,deleteLogs
, etc.) to return the deleted entitiesMemoryConnector
implementation to match the new interfaceReorgHandler
to handle the new return valueHow to test?
Why make this change?
This change improves the reorg handling process by providing access to the deleted block data, which can be useful for: