Merged
Conversation
tkersey
reviewed
Feb 28, 2025
| for skill in skills_data["skills"] | ||
| for developer in skill["developerSkills"] | ||
| } | ||
| return {developer["developer"]["name"] for skill in skills_data["skills"] for developer in skill["developerSkills"]} |
Contributor
There was a problem hiding this comment.
I know this is just what your formatter does but which one do you actually think is easier to read?
Contributor
Author
There was a problem hiding this comment.
may be 120 lines is too big? at 100 formatter would be multiline. what you think?
Contributor
There was a problem hiding this comment.
Does that mean you prefer the multi-line version? I'm open to either.
tkersey
reviewed
Feb 28, 2025
| @@ -0,0 +1,27 @@ | |||
| #-------------------------------------------------------------------------------# | |||
Contributor
There was a problem hiding this comment.
Tell me more about this tool.
Contributor
Author
There was a problem hiding this comment.
built in for PyCharm: https://www.jetbrains.com/qodana/
tkersey
reviewed
Feb 28, 2025
tkersey
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.