Fix: update test assertions for statistical success rate and adjust s…#58
Merged
kseebaldt merged 3 commits intothisisartium:mainfrom Mar 21, 2025
Merged
Fix: update test assertions for statistical success rate and adjust s…#58kseebaldt merged 3 commits intothisisartium:mainfrom
kseebaldt merged 3 commits intothisisartium:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates test assertions for statistical success rate evaluation and adjusts test sample sizes.
- The expected success count is now cast to an integer.
- Type hints have been added to the utility function is_within_a_range.
- Test cases in both helper and loop tests have been updated to reflect new sample sizes and statistical expectations.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/team_recommender/tests/helpers.py | Casting expected success count to int and updating test cases. |
| examples/team_recommender/tests/example_3_loop/test_allocations_loop.py | Updated assertion to check existence of at least one success. |
| .github/workflows/python-tests.yml | Minor whitespace changes in the test workflow. |
paulz
approved these changes
Mar 20, 2025
Contributor
paulz
left a comment
paulz
left a comment
There was a problem hiding this comment.
added minor readability changes here: dipolesource#1
should be even more precise, but it's an improvement made by AI without giving human a chance to edit Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ample size