Add some tests for formatting time for display! #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add requirements.dev.txt to install py.test - Refactor Timer slightly so we can call the formatting method without an instance - Add some tests! Just include some examples that span the range from seconds to hours, and verify that they display properly.
|
Awesome, thank you so much! |
|
Oh I forget to mention -- just run This is often where I'll start testing an extant piece of code -- don't try to test everything, but find bits that are easy to exercise automatically and useful (in this case, especially because testing by hand otherwise involves waiting an hour or hacking something up!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an instance
seconds to hours, and verify that they display properly.