Working in ability to enable and disable units #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a Struct and Pair class as needed by dbus-java - Updated various versions I am labeling this version as 2.2.0-eks so if this commit is accepted, be sure to remove -eks. --- In a working state. Needed to also use a special struct class for the disableUnitFiles call (+3 squashed commit) Squashed commit: [9dde539] Found that `enableUnitFiles` may perform what I need to get units started. The `List<UnitFileChange>` is not the proper return type. Some research lead me to AgNO3 project that uses a Tuple type of structure to hold the return type: https://github.com/AgNO3/code/blob/main/orchestrator/agent/system/eu.agno3.orchestrator.system.init.systemd/src/main/java/org/freedesktop/systemd1/Manager.java Still experimenting... [7197b50] WIP: TDD and fleshing out unit creation with dbus [fb4e92d] Starting work towards creating/update/delete units - Specifically service units for now. - Using my own version number - Using lombok to reduce builder code. thjomnx#6 (comment)
|
FYI, not sure if you noticed: Issue #4 looks pretty much related. Happy to see some attempt to fix it, as I didn't find the time ever since... 👍 |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am labeling this version as 2.2.0-eks so if this commit is accepted,
be sure to remove -eks.
FYI - For now, I needed to remove the
-SNAPSHOTversioning since I will need to use this version in my system.In a working state. Needed to also use a special struct class for the disableUnitFiles call (+3 squashed commit)
Squashed commit:
[9dde539] Found that
enableUnitFilesmay perform what I need to get units started.The
List<UnitFileChange>is not the proper return type. Some research lead me to AgNO3 project that uses a Tuple type of structure to hold the return type: https://github.com/AgNO3/code/blob/main/orchestrator/agent/system/eu.agno3.orchestrator.system.init.systemd/src/main/java/org/freedesktop/systemd1/Manager.javaStill experimenting...
[7197b50] WIP: TDD and fleshing out unit creation with dbus
[fb4e92d] Starting work towards creating/update/delete units