Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix humidity warning #716

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GrimmiMeloni
Copy link

HM-IP-eTRV2 is detected as ThermostatServiceIP, however it does not have a humidity value.
This causes some unnecessary warnings in the logs, which this change fixes.

@bcschwede
Copy link

Hi there,
I see warnings of this kind in my homebridge logs: " [homebridge-homematic] This plugin generated a warning from the characteristic 'Current Relative Humidity': characteristic value expected valid finite number and received "NaN" (number). See https://homebridge.io/w/JtMGR for more info."
Probably you solved this problem - can i be of any help in testing? How can I install this fix?
Best,
BC

@GrimmiMeloni
Copy link
Author

Correct, this fix takes care of this warning.
Not sure if testing is required. It would take @thkl to accept the PR into his repo and create a new release of the plugin.
Alternatively you can checkout this branch and install the plugin manually into home bridge.

Copy link

@redtom13 redtom13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants