Fix incorrect pixel values in empty latent error message #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example: a valid image size of 960x544 would show an error message of: "Latent dimensions must be divisible by 16. Got 68x120. For a 544x960 pixel image, use a 64x112 latent". The bug is because the original code used height and width values from the shape object to populate error messages, but these are NOT pixel values because they have undergone //8 for latent compression. So the error message values were incorrect and confusing (and had height, width rather than the conventional order of width, height).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: a valid image size of 960x544 would show an error message of: "Latent dimensions must be divisible by 16. Got 68x120. For a 544x960 pixel image, use a 64x112 latent". The bug is because the original code used height and width values from the shape object to populate error messages, but these are NOT pixel values because they have undergone //8 for latent compression. So the error message values were incorrect and confusing (and had height, width rather than the conventional order of width, height).