-
Notifications
You must be signed in to change notification settings - Fork 57
Multiple changes #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Multiple changes #39
Conversation
jogibear9988
commented
Aug 22, 2024
- switch to new csproj file format.
- create a version for net472 and net8
- automaticly load correct openssl dll
- switch to ne solution file format (slnx)
- automatic load openSSL in the correct version (x86/x64)
|
Maybe the switch to slnx is a little bit early and should not be done yet, I need to look if building with dotnet command is already possible atm. |
|
I also added your fix in zlib to cinderblocks/zlib.net#5 |
|
I can't use .Net Core, and I have to stay at Visual Studio 2019 for some reason. |
|
I had to fix a bug in zlib.net, which is also still present in the .Net core version (maybe no one used zlib with dictionaries, or .Net core handles type casts in a different manner). So I'd like to keep it internally, also I prefer to reduce external dependencies to an absolute minimum. Download the source, and you should be ready to go. |
|
I've seen the bug, I've created a pull with your fix at a zlib nuget package. wich merged it : cinderblocks/zlib.net#5 But no problem to keep it internal. |
|
VS2019 should be possible ( I think, need to try), but for sure the SLNX will not work |
|
@thomas-v2 my changes compile now also in VS2019 |
-> switching dll names does not work very well, and openssl has -x64 on the 64bit dlls. atm supporting full framework is not needed add support for win arm (needs test) and osx (needs test)
# Conflicts: # src/S7CommPlusGUIBrowser/Form1.cs
install_name_tool -change /tmp/openssl-arm/lib/libcrypto.3.dylib @rpath/libcrypto.3.dylib libssl.3.dylib install_name_tool -add_rpath @loader_path libssl.3.dylib
# Conflicts: # src/S7CommPlusDriver/S7CommPlusConnection.cs # src/S7CommPlusDriver/S7CommPlusDriver.csproj # src/S7CommPlusGUIBrowser/Form1.Designer.cs # src/S7CommPlusGUIBrowser/Form1.cs # src/S7CommPlusGUIBrowser/Form1.resx