Skip to content

Conversation

@syedzayyan
Copy link
Contributor

@syedzayyan syedzayyan commented Oct 9, 2025

Checklist

  • I've formatted the new code by running uv run poe format before committing.
  • I've added tests for new code.
  • I've added docstrings for the new code.

Description

This is an implementation of an edge kernel. I have added new the kernel implementations, a new test and a rudimentary working docs. I would like if someone could:

  • check the language of the docs and see where they could be better explanations or any pointers would be lovely.
  • overall kernel implementation and if I am doing something wrong.
  • I have a new computation function because vmap does not like complicated indexing, if anyone has better vectorisation ideas, would love to hear.

Code inspiration is taken from the supplementary provided here.

@thomaspinder
Copy link
Owner

Hi @syedzayyan . Thanks for the PR! I need a few days to look into this - I'll reply shortly

@thomaspinder
Copy link
Owner

Hi @syedzayyan, my feeling is that this is a little too niche for the source codebase. How would you feel about migrating it into a didactic notebook, similar to our Ocean Modelling notebook.

@syedzayyan
Copy link
Contributor Author

Yes it does seem like a wrapper around a stationery kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants