feat: add support for all retrievers in cli #4025

DeamonDev · 2025-10-06T07:19:27Z

Description

I added new flags related to other kind of retrievers. Based on them the new retriever is being spawned (but see #4024).
There is also new --check-mode flag which when present would only dump the configuration of retriever being used to perform evaluate call. It also served me while testing some multi-flags (like http's --header) because there is some kind of parsing logic at evaluate_cmd layer.

The redis retriever is not supported because of #4023. We may of course hack it and provide empty output when -kind=redis but I think the refactor of RetrieverConf struct would benefit more.

Closes issue(s)

Resolve #3876

Checklist

I have tested this code
I have added unit test to cover this code
I have updated the documentation (README.md and /website/docs)
I have followed the contributing guide

Signed-off-by: deamondev <[email protected]>

netlify · 2025-10-06T07:19:32Z

✅ Deploy Preview for go-feature-flag-doc-preview canceled.

Name	Link
🔨 Latest commit	`fcf358d`
🔍 Latest deploy log	https://app.netlify.com/projects/go-feature-flag-doc-preview/deploys/68e36d81b4b40f0008b3224f

sonarqubecloud · 2025-10-06T07:20:27Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-10-06T07:23:50Z

Codecov Report

❌ Patch coverage is 89.37500% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.04%. Comparing base (4c730fb) to head (fcf358d).
⚠️ Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/cli/evaluate/evaluate_cmd.go	91.61%	8 Missing and 5 partials ⚠️
retriever/gcstorageretriever/retriever.go	0.00%	2 Missing ⚠️
retriever/s3retrieverv2/retriever.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4025      +/-   ##
==========================================
+ Coverage   83.92%   84.04%   +0.11%     
==========================================
  Files         137      137              
  Lines        6813     6968     +155     
==========================================
+ Hits         5718     5856     +138     
- Misses        884      897      +13     
- Partials      211      215       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

thomaspoignant · 2025-10-13T18:42:36Z

retriever/s3retrieverv2/retriever.go

+
+func (s *Retriever) SetDownloader(downloader DownloaderAPI) {
+	s.downloader = downloader
+}


Just to be sure, why do you need this function?
You can probably set the downloader directly in the struct?

thomaspoignant · 2025-10-13T19:30:49Z

/gemini review

gemini-code-assist

Code Review

This pull request significantly enhances the CLI by adding support for all retrievers, which is a great feature. The implementation introduces a --check-mode for inspecting retriever configurations, which is very useful for debugging.

My review focuses on improving documentation clarity, fixing a parsing bug, and some minor code cleanup. I've identified a few issues in the README.md that could confuse users, a bug in the HTTP header parsing logic, and some opportunities for code refinement in the tests and command implementation.

Overall, this is a solid contribution. Addressing the feedback will make the new CLI features more robust and easier to use.

gemini-code-assist · 2025-10-13T19:32:37Z

cmd/cli/evaluate/evaluate_cmd.go

+func parseHTTPHeaders() map[string][]string {
+	result := make(map[string][]string)
+	for _, h := range headers {
+		parts := strings.SplitN(h, "=", 2)
+		if len(parts) != 2 {
+			parts = strings.SplitN(h, ":", 2)
+		}
+		if len(parts) != 2 {
+			continue
+		}
+		key := strings.TrimSpace(parts[0])
+		val := strings.TrimSpace(parts[1])
+		result[key] = append(result[key], val)
+	}
+	return result
+}


The current parsing logic for HTTP headers can lead to incorrect key-value pairs if a header value contains an = character. The logic attempts to split by = before splitting by :. It should be the other way around, as : is the standard separator for HTTP headers. For example, a header like Some-Header: key=value would be incorrectly parsed. Swapping the order of checks will fix this.

Suggested change

func parseHTTPHeaders() map[string][]string {

result := make(map[string][]string)

for _, h := range headers {

parts := strings.SplitN(h, "=", 2)

if len(parts) != 2 {

parts = strings.SplitN(h, ":", 2)

}

if len(parts) != 2 {

continue

}

key := strings.TrimSpace(parts[0])

val := strings.TrimSpace(parts[1])

result[key] = append(result[key], val)

}

return result

}

func parseHTTPHeaders() map[string][]string {

result := make(map[string][]string)

for _, h := range headers {

parts := strings.SplitN(h, ":", 2)

if len(parts) != 2 {

parts = strings.SplitN(h, "=", 2)

}

if len(parts) != 2 {

continue

}

key := strings.TrimSpace(parts[0])

val := strings.TrimSpace(parts[1])

result[key] = append(result[key], val)

}

return result

}

gemini-code-assist · 2025-10-13T19:32:37Z

cmd/cli/README.md

+|------------|---------------------------------------------------------------------|---------|
+| `--url`    | URL of the remote flag configuration file                           | ""      |
+| `--method` | HTTP method to access your configuration file on HTTP               | ""      |
+| `--body`   | Http body to access your configuration file on HTTP                 | GET     |


The default value for --body is documented as GET, which is incorrect. GET is the default for the --method flag. The default for --body should be an empty string ("").

Suggested change

| `--body` | Http body to access your configuration file on HTTP | GET |

| `--body` | Http body to access your configuration file on HTTP | "" |

gemini-code-assist · 2025-10-13T19:32:37Z

cmd/cli/README.md

+| `--repository-slug` |                                                                                                                   | ""      |
+| `--branch`          | Name of the repository                                                                                            | ""      |
+| `--auth-token`      | Authentication token to access your configuration file                                                            | ""      |
+| `--github-token`    | Authentication token to access your configuration file on GitHub<br/> (⚠️ deprecated, use `--auth-token` instead) | ""      |
+| `--path`            | Path to the remote flag configuration file inside github repository                                               | ""      |
+
+#### GitLab
+
+| Flag                | Description                                                         | Default |
+|---------------------|---------------------------------------------------------------------|---------|
+| `--base-url`        | Base URL of your configuration file on Gitlab                       | ""      |
+| `--repository-slug` | Name of the repository                                              | ""      |
+| `--branch`          | Name of the repository                                              | ""      |
+| `--path`            | Path to the remote flag configuration file inside gitlab repository | ""      |
+
+#### BitBucket
+
+| Flag                | Description                                                            | Default |
+|---------------------|------------------------------------------------------------------------|---------|
+| `--base-url`        | Base URL of your configuration file on BitBucket                       | ""      |
+| `--repository-slug` | Name of the repository                                                 | ""      |
+| `--branch`          | Name of the repository                                                 | ""      |
+| `--path`            | Path to the remote flag configuration file inside bitbucket repository | ""      |


There are several documentation issues in the tables for Git-based retrievers (GitHub, GitLab, BitBucket):

GitHub (--repository-slug): The description is missing.

GitHub, GitLab, BitBucket (--branch): The description is incorrectly 'Name of the repository'. It should describe the branch.

GitLab, BitBucket (--repository-slug): The description is incorrectly 'Name of the repository'. It should describe the repository slug.

Please update these descriptions for clarity. For example, you could use 'Repository slug (e.g., owner/repo)' and 'Git branch name'.

gemini-code-assist · 2025-10-13T19:32:38Z

cmd/cli/evaluate/evaluate_cmd.go

+		"column", nil, "Postgres column mapping of your configuration file on Postgres (may be repeated)")
+	_ = evaluateCmd.Flags().MarkDeprecated("github-token", "Use auth-token instead")
+	_ = evaluateCmd.Flags().MarkDeprecated("config", "Use path instead")
+	_ = evaluateCmd.Flags()


This line of code has no effect and can be safely removed.

gemini-code-assist · 2025-10-13T19:32:38Z

cmd/cli/evaluate/evaluate_cmd_test.go

+			expectedResult: "testdata/res/check-gcs.json",
+		},
+		{
+			name: "should return configuration of GCS retriever when using check-mode",


This test case has an incorrect name. It's named for the GCS retriever but is testing the configmap retriever.

Suggested change

name: "should return configuration of GCS retriever when using check-mode",

name: "should return configuration of configmap retriever when using check-mode",

gemini-code-assist · 2025-10-13T19:32:38Z

cmd/cli/evaluate/evaluate_test.go

 func Test_evaluate_Evaluate(t *testing.T) {
 	tests := []struct {
 		name           string
 		evaluate       evaluate


The evaluate field in this test struct is no longer used since the introduction of initEvaluate. It can be removed to improve code clarity.

DeamonDev added 21 commits October 4, 2025 21:17

add support for github retriever

2f2665d

Signed-off-by: deamondev <[email protected]>

refactor evaluate struct

812c65d

Signed-off-by: deamondev <[email protected]>

add gitlab retriever support

9bb98da

Signed-off-by: deamondev <[email protected]>

fix formatting

a89ab25

Signed-off-by: deamondev <[email protected]>

add support for bitbucket retriever

09d5f1e

Signed-off-by: deamondev <[email protected]>

add support for s3 retriever

448aa69

Signed-off-by: deamondev <[email protected]>

start adding support for http retriever

1c05e87

Signed-off-by: deamondev <[email protected]>

add test for http retriever

8d62a36

Signed-off-by: deamondev <[email protected]>

add check flag

1163fa1

Signed-off-by: deamondev <[email protected]>

add test for evaluate cmd http retriever

15052c2

Signed-off-by: deamondev <[email protected]>

add more tests

86ffc80

Signed-off-by: deamondev <[email protected]>

add more tests for s3 and bitbucket

f551f0d

Signed-off-by: deamondev <[email protected]>

add support for gcs

6e54164

Signed-off-by: deamondev <[email protected]>

little refactor

2d97760

Signed-off-by: deamondev <[email protected]>

add support for mongodb

fc3678b

Signed-off-by: deamondev <[email protected]>

add support for azure and postgres

fadeb12

Signed-off-by: deamondev <[email protected]>

start writing docs

8230bce

Signed-off-by: deamondev <[email protected]>

add readme

d09c14f

Signed-off-by: deamondev <[email protected]>

add timeout in docs

58acc14

Signed-off-by: deamondev <[email protected]>

link redis options issue

e0fb0ca

Signed-off-by: deamondev <[email protected]>

add todo comment

fcf358d

Signed-off-by: deamondev <[email protected]>

github-actions bot assigned thomaspoignant Oct 6, 2025

github-actions bot requested a review from thomaspoignant October 6, 2025 07:19

DeamonDev changed the title ~~Feature add support for all retrievers in cli~~ feature: add support for all retrievers in cli Oct 6, 2025

DeamonDev changed the title ~~feature: add support for all retrievers in cli~~ feat: add support for all retrievers in cli Oct 6, 2025

DeamonDev mentioned this pull request Oct 6, 2025

(change) Add serializable configuration layer for redis options in struct describing configuration of retriever #4023

Open

thomaspoignant reviewed Oct 13, 2025

View reviewed changes

gemini-code-assist bot reviewed Oct 13, 2025

View reviewed changes

	\| `--body` \| Http body to access your configuration file on HTTP \| GET \|
	\| `--body` \| Http body to access your configuration file on HTTP \| "" \|

	name: "should return configuration of GCS retriever when using check-mode",
	name: "should return configuration of configmap retriever when using check-mode",

Uh oh!

feat: add support for all retrievers in cli #4025

Are you sure you want to change the base?

feat: add support for all retrievers in cli #4025

Conversation

DeamonDev commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Closes issue(s)

Checklist

Uh oh!

netlify bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for go-feature-flag-doc-preview canceled.

Uh oh!

sonarqubecloud bot commented Oct 6, 2025

Quality Gate passed

Uh oh!

codecov bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

thomaspoignant Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

thomaspoignant commented Oct 13, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DeamonDev commented Oct 6, 2025 •

edited

Loading

netlify bot commented Oct 6, 2025 •

edited

Loading

codecov bot commented Oct 6, 2025 •

edited

Loading