-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/#1688 workflows #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5fb736b to
e3b8d28
Compare
| brief: > | ||
| Workflows seek to describe the execution of one ore more tasks to achieve an end result. | ||
|
|
||
| Workflows can be used to describe cicd, deployments, generic jobs or even cron jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A consumer of SemConv for CI/CD might not know to look in workflow for CI/CD conventions.
What can we do to make this clearer?
Can we improve the docs/cicd/README.md or docs/cicd/cicd-spans and link to the workflows page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree a key thing would be to ensure that the docs are easily discoverable to a user.
What I am thinking is we focus on having mapping documents ie a github doc within the cicd section which brings in the appropriate definitions regardless of the definition namespace that way a reader can simply browse based on the topic and not need. This would also mean that the generic spans doc would also include the spans from Workflow namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do these spans relate to the cicd-spans?
Would these replace the existing cicd-spans (ie deprecate them) or complement them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the intention would be the spans replace the cicd spans.
If my understanding of cicd spans/concept is correct and how they would map to a system such as github.
- the cicd pipeline run would be the Workflow task execution span
- the cicd pipeline task run would need a new span Workflow step run and the corresponding attributes.
|
Previous PR that was auto-closed due to missing SIG: |
467a354 to
f41268a
Compare
Signed-off-by: James Thompson <[email protected]>
Signed-off-by: James Thompson <[email protected]>
Signed-off-by: James Thompson <[email protected]>
Co-authored-by: Christophe Kamphaus <[email protected]>
c8eaafb to
18cbf19
Compare
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 14 days. |
Fixes #
Changes
This PR is intended to serve as a goal post for workflows with the pr intended to be submitted to semconv in bite sized pieces Starting off with the highest level Workflow & working way down.
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]