Fix packaging to create odpdown console script #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The odpdown command-line script was not being created on installation. This was caused by two issues: 1. The build system was getting confused by the ambiguous project structure (both `odpdown.py` and an `odpdown/` directory). 2. The `pyproject.toml` was missing the `[project.scripts]` definition. This commit resolves the ambiguity by explicitly telling the PDM build backend to only include the `odpdown/` directory in the final package. It also adds the missing script definition. This allows the legacy `odpdown.py` file to remain in the repository for any users who may depend on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
When I installed
odpdownwithuvorpip, theodpdowncommand wasn't being created in my path.It looks like the build system was getting confused by the project having both an
odpdown.pyfile and anodpdown/directory.This PR fixes it by explicitly telling the PDM build tool to use the
odpdown/directory, which resolves the ambiguity. It also adds the missing[project.scripts]definition.This approach fixes the modern packaging while leaving the old
odpdown.pyfile in place for anyone who might still be using it directly.Hope this helps!