TextMetrics: introduced a sample for advanced text usages#28
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new TextMetrics example demonstrating advanced text manipulation capabilities including a simple text editor with cursor positioning, line wrapping, and basic text input handling. It extends the example framework to support keyboard events.
Changes:
- Added keyboard event handling to the example framework (keydown callback, shift key tracking)
- Created TextMetrics.cpp demonstrating text metrics API with an interactive text editor
- Added TextMetrics.cpp to the build configuration
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| src/meson.build | Added TextMetrics.cpp to the build list |
| src/TextMetrics.cpp | New interactive text editor example demonstrating text metrics, cursor positioning, and line tracking |
| src/Example.h | Added keydown virtual method and lshift tracking to support keyboard input in examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hermet
force-pushed
the
hermet/textmetrics
branch
from
4501f12 to
7f88309
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depending on: thorvg/thorvg#4177
2026-02-26-16-30-56.mp4