example: gurantee destroying user data before canvas destruction#29
Merged
example: gurantee destroying user data before canvas destruction#29
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts teardown order in the example window backends so user Example state is destroyed before the ThorVG Canvas, and moves Example/Canvas deletion out of the base Window destructor into backend-specific destructors.
Changes:
- Remove
example/canvasdeletion fromWindow::~Window(). - Add
SwWindowdestructor to deleteexampleandcanvas. - Update
GlWindow/WgWindowdestructors to deleteexamplebeforecanvas(and removecanvas = nullptr).
Comments suppressed due to low confidence (2)
src/Example.h:180
Window::~Window()no longer deletesexample/canvas, so anyWindowsubclass that doesn’t implement a destructor to delete them will now leak (e.g., the non-TVGEXAMPLE_WGPU_SUPPORTEDWgWindowvariant has no destructor). Either restore ownership inWindow(with correct ordering relative to backend teardown) or add destructors for every subclass/variant to deleteexample(andcanvaswhen applicable).
virtual ~Window()
{
//Terminate the SDL
SDL_DestroyWindow(window);
SDL_Quit();
//Terminate ThorVG Engine
tvg::Initializer::term();
}
src/Example.h:513
WgWindowcan early-return from its constructor when!initialized, leavinginstance/surface/adapter/deviceuninitialized. The destructor unconditionally releases all of them, which is undefined behavior if creation didn’t complete. Initialize these handles tonullptrat declaration and guard eachwgpu*Release()so it only runs for non-null handles.
virtual ~WgWindow()
{
delete(example);
delete(canvas);
wgpuDeviceRelease(device);
wgpuAdapterRelease(adapter);
wgpuSurfaceRelease(surface);
wgpuInstanceRelease(instance);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.