Open
Conversation
TvgLib.cs: Clean up formatting, remove unused Unity/System using directives, simplify enum references, and update the native canvas API call from tvg_canvas_push to tvg_canvas_add (adjusted DllImport and call site). Miscellaneous comment/whitespace tidy. scripts/build-thorvg.py: Make build outputs more robust by setting the working directory, updating the example tag, and changing UNITY_PLUGINS path resolution. Add find_built_library() to auto-discover real (non-symlink) ThorVG artifacts and use it across desktop, iOS, Android and WASM flows instead of hardcoded src paths; improve error messages and copying logic. Also normalize THORVG_DIR construction.
Add using directives for System and UnityEngine to package/Runtime/Sys/TvgLib.cs. These imports enable use of core .NET types and Unity APIs in the file (previously only Runtime.InteropServices was imported).
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Unity ThorVG integration to work with ThorVG v1.0+ by adjusting the native build script outputs and aligning the C# P/Invoke surface with the updated ThorVG C API.
Changes:
- Update build script paths to be deterministic and auto-detect/copy the built library artifacts across desktop/iOS/Android/WebGL builds.
- Switch C# interop from
tvg_canvas_pushtotvg_canvas_addand clean up related enum usage/formatting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/build-thorvg.py | Ensures builds run from a consistent working directory and copies platform artifacts by auto-discovery (instead of hardcoded filenames/paths). |
| package/Runtime/Sys/TvgLib.cs | Updates the native canvas API binding to tvg_canvas_add (ThorVG v1.0+) and normalizes internal enum references/formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hermet
added
infrastructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the build tools to support ThorVG v1.0 and above