-
-
Notifications
You must be signed in to change notification settings - Fork 13
feat: add typedoc to synchronize codebase's api #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pending for squash commit. (solve coflict) |
Merge conflict solved and did squash commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates TypeDoc to automatically generate API documentation from TypeScript code, replacing the manually maintained API documentation in README.md with an automated documentation solution.
- Adds TypeDoc configuration and build scripts for generating HTML documentation
- Removes manually maintained API documentation section from README.md
- Adds TSDoc comments to the LottiePlayer class as an example
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
typedoc.json | Configuration file for TypeDoc documentation generation |
src/lottie-player.ts | Adds TSDoc comments to LottiePlayer class |
package.json | Adds TypeDoc dependency and documentation build scripts |
README.md | Removes manually maintained API documentation section |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Please check wrong spelling and typo in commit message.
Also I am curious about "Remain Issue" section.
If the issue is valid and you know way out, then please make a decision and apply and request review again.
A commit message is not a place to pass unresolved issues on to future contributors.
If even the PR author considers a patch incomplete (because a valid issue still exists), I don’t think it makes sense for reviewers to spend time reviewing it.
Thank you for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- add typedoc to parse jsdoc to html file. - delete api explanation on README.md. - Because codebase is based on typescript, use typedoc instead of jsdoc. Typedoc support tsdoc and jsdoc both.
- Create web-based example matching thorvg's Lottie.cpp behavior - Display animations in 10x10 grid layout with gray background - Copy lottie animation resources to avoid thorvg dependency - Include performance monitoring (FPS/MS/Memory) stats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

base-lottie-player and lottie-preset-player are not public classes. Users have no idea about them.
I don’t understand that the documentation is focused on classes that users can’t access.
Please note, users don't use pure typescript classes. Every scripts are built to library bundle and users will use the that.
I think docs should describe library bundle usage.
"tsconfig": "./tsconfig.json", | ||
"plugin": [], | ||
"theme": "default", | ||
"name": "@thorvg/thorvg.web", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thorvg/lottie-player
This change doesn’t synchronize the package’s API, just adds the Typedoc library. |
Description
typedoc
to parsejsdoc
tohtml
files.typedoc
due tojsdoc
not support for typescript (it needs transfiling to js, and could generate jsdoc using comments)typedoc
supportjsdoc
andtsdoc
both.tsdoc
is made by microsoft fortypescript
.Changes
Example Images
Build docs
build
command, output likes:Docs Examples
Considerations
typedoc
which uses Microsoft'stsdoc
sinceThorvg.web
is usingtypescript
instead ofjavascript
/docs
in.gitignore
, because it build separately and might be used inThroVG
's api docs (guess maintainer will do CI/CD).lottie-player
exists insrc
, so this is set as the entry point (the"entryPoints"
option in the configuration file may need to be modified later)LottiePlayer
class. But, need to consider leave comments tsdoc style.jsdoc
also can use in typedoc, buttsdoc
allow a lot of features for typescript.typedoc
, so not that big issues)typedoc
plugin or waiting to update futher.Relative Issue
#21