Prevent inlining big functions #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #29. This prevents inlining big functions by putting the bulk of the fetch code in non-inlined
__tryFetchAsfunction that receives the data and responseTypearguments.tryFetchAsis still inlined but now the only thing it does is generating the types withtypeofand passing them to__tryFetchAs.Note: it should be possible to mark
__tryFetchAswithinternalso it's not visible to consumers. But sometimes I get errors from the F# compiler when inlined functions call private/internal functions so for now I'm just prefixing it with__.