Skip to content

Feature/field constraints#748

Merged
ja573 merged 4 commits into
developfrom
feature/field-constraints
May 6, 2026
Merged

Feature/field constraints#748
ja573 merged 4 commits into
developfrom
feature/field-constraints

Conversation

@ja573

@ja573 ja573 commented May 5, 2026

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e675ffad47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 671 to 672
.map(|text| convert_to_jats(text, markup, ConversionLimit::Abstract))
.transpose()?;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Authorize endorsement update before parsing rich text

Run the policy check before convert_to_jats here, otherwise unauthenticated/unauthorized callers can still force JATS conversion work and receive conversion errors before the permission denial. This changed behavior from the previous ordering and is inconsistent with nearby update mutations (e.g. additional resources, awards, book reviews), which short-circuit on authorization first.

Useful? React with 👍 / 👎.

@ja573 ja573 merged commit 6d69601 into develop May 6, 2026
11 checks passed
@ja573 ja573 deleted the feature/field-constraints branch May 6, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant