Feature/field constraints#748
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e675ffad47
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .map(|text| convert_to_jats(text, markup, ConversionLimit::Abstract)) | ||
| .transpose()?; |
There was a problem hiding this comment.
Authorize endorsement update before parsing rich text
Run the policy check before convert_to_jats here, otherwise unauthenticated/unauthorized callers can still force JATS conversion work and receive conversion errors before the permission denial. This changed behavior from the previous ordering and is inconsistent with nearby update mutations (e.g. additional resources, awards, book reviews), which short-circuit on authorization first.
Useful? React with 👍 / 👎.
No description provided.