Create alias for certain operations #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the name of certain operations. This change has effect on v1beta1. However, to be able to consume configs written with v1alph1, we're keeping the old names. The operations that now have a new alias are: - "and" -> "all" - "or" -> "any" - "forEach" -> "map" Appart from that, we're changing the behaviour of "or" (and "any) when they have no operands. Before, the result was true, but now it's false. This makes this operation consistent with `any([])` in Python. The intention is to make it's output more intuitive for Python users.
jordipiqueselles
force-pushed
the
jordi/op-alias
branch
from
b55c375 to
06b28a4
Compare
jordipiqueselles
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the name of certain operations. This change has an effect on v1beta1. However, to be able to consume configs written with v1alpha1, we're keeping the old names. The operations that now have a new alias are:
Apart from that, we're changing the behavior of "or" (and "any) when they have no operands. Before, the result was true, but now it's false. This makes this operation consistent with
any([])in Python. The intention is to make its output more intuitive for Python users.