Add strict mode for interface comparison#1
Merged
Merged
Conversation
thiagoa
force-pushed
the
strict-mode
branch
3 times, most recently
from
9497a72 to
d2779d8
Compare
Extract KeywordNormalizer and SequentialNormalizer from ParamsNormalizer. Add DefaultParamsNormalizer (both normalizers) and StrictParamsNormalizer (keywords only), where strict mode makes positional argument names significant. ParamsNormalizer becomes a factory via ParamsNormalizer.for(strict:). Thread strict: false through InterfaceChecker, BulkInterfaceChecker, and both test helpers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeywordNormalizerandSequentialNormalizerfromParamsNormalizer, which becomes a factory viaParamsNormalizer.for(strict:)DefaultParamsNormalizer(sorts keywords + sequentializes positional names) andStrictParamsNormalizer(sorts keywords only, preserving positional names)strict: falsetoInterfaceChecker,BulkInterfaceChecker,assert_interfaces_match, andhave_matching_interfaces/ shared exampleIn strict mode, positional argument names must match exactly. Keyword argument names always matter regardless of this setting.
Test plan
bundle exec rake cipassesInterfaceCheckerTestcovers strict mode behaviourstrict:option for all integration points🤖 Generated with Claude Code