Add latest Ruby and Rails versions to the build #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilvcarvalho
force-pushed
the
nc-build-newer-rails
branch
from
94dc715 to
1bba51b
Compare
The Rails versions had been added to the Appraisals file in previous PRs, but GitHub Actions didn't run with them because the `build.yml` file hadn't been changed.
neilvcarvalho
force-pushed
the
nc-build-newer-rails
branch
2 times, most recently
from
8596d90 to
069a1e8
Compare
The `drb` gem is not a default gem on Ruby 3.4 anymore, so it needs to be on the Gemfile. Rails 7.1 and above already include it as a dependency.
neilvcarvalho
force-pushed
the
nc-build-newer-rails
branch
from
069a1e8 to
c2636a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.2 and 8.0 had been added to the Appraisals file in previous PRs, but GitHub Actions didn't run with them because the build.yml file hadn't been changed.
This PR addresses that by adding Rails 7.2 and 8.0 to the test matrix.
Another change it introduces is adding Ruby 3.4 to the test matrix. The Appraisal definition for older Rails version had to be changed because of this change, as the
drbgem isn't included in the standard library anymore and was only added in Rails 7.1 onwards.