Skip to content

Support Rails 8.1 #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neilvcarvalho merged 3 commits into from
Dec 29, 2025
Merged

Support Rails 8.1 #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c01a13
deps: Require minitest ~> 5.27
toshimaru Dec 24, 2025
68ef822
ci: Add rails 8.1
toshimaru Dec 24, 2025
e5be4ac
Create rails8.1.gemfile via appraisal
toshimaru Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,15 @@ jobs:
strategy:
fail-fast: false
matrix:
rails: ["8.0", "7.2", "7.1", "7.0", "6.1"]
rails: ["8.1", "8.0", "7.2", "7.1", "7.0", "6.1"]
ruby: ["3.4", "3.3", "3.2", "3.1"]
exclude:
# Rails >= 8.0 requires Ruby 3.2
- ruby: "3.1"
rails: "8.0"
# Rails >= 8.1 requires Ruby 3.2
- ruby: "3.1"
rails: "8.1"


runs-on: 'ubuntu-latest'
Expand Down
20 changes: 20 additions & 0 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ appraise "rails6.1" do
gem "spring", "!= 2.1.1"
gem "spring-watcher-listen", "~> 2.0.0"
gem "sqlite3", "~> 1.4"
gem "minitest", "~> 5.27"
end

appraise "rails7.0" do
Expand All @@ -22,6 +23,7 @@ appraise "rails7.0" do
gem "spring", "!= 2.1.1"
gem "spring-watcher-listen", "~> 2.0.0"
gem "sqlite3", "~> 1.4"
gem "minitest", "~> 5.27"
end

appraise "rails7.1" do
Expand All @@ -32,6 +34,7 @@ appraise "rails7.1" do
gem "spring", "!= 2.1.1"
gem "spring-watcher-listen", "~> 2.0.0"
gem "sqlite3", "~> 1.4"
gem "minitest", "~> 5.27"
end

appraise "rails7.2" do
Expand All @@ -42,6 +45,7 @@ appraise "rails7.2" do
gem "spring", "!= 2.1.1"
gem "spring-watcher-listen", "~> 2.0.0"
gem "sqlite3", "~> 1.4"
gem "minitest", "~> 5.27"
end

appraise "rails8.0" do
Expand All @@ -57,4 +61,20 @@ appraise "rails8.0" do
gem "spring-watcher-listen", "~> 2.0.0"
gem "sqlite3", ">= 2.1"
gem "thruster"
gem "minitest", "~> 5.27"
end

appraise "rails8.1" do
gem "bcrypt"
gem "brakeman"
gem "bundler-audit"
gem "kamal"
gem "minitest", "~> 5.27"
gem "puma"
gem "rails", "~> 8.1.0"
gem "rubocop-rails-omakase"
gem "solid_cache"
gem "solid_queue"
gem "sqlite3", ">= 2.1"
gem "thruster"
Comment on lines +68 to +79
Copy link

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rails8.1 block is missing several dependencies that are consistently present in rails8.0 and all Rails 7.x version blocks. The following gems should be added for consistency:

  • byebug (for debugging support)
  • listen ~> 3.2 (for file watching)
  • spring != 2.1.1 (application preloader)
  • spring-watcher-listen ~> 2.0.0 (Spring file watcher integration)

Additionally, puma should have a version constraint (~> 6.0) to match the pattern used in rails7.1, rails7.2, and rails8.0.

The presence of bcrypt, bundler-audit, and solid_cache appears inconsistent with the rails8.0 block and may not be necessary in the Appraisals file if they are transitive dependencies.

Suggested change
gem "bcrypt"
gem "brakeman"
gem "bundler-audit"
gem "kamal"
gem "minitest", "~> 5.27"
gem "puma"
gem "rails", "~> 8.1.0"
gem "rubocop-rails-omakase"
gem "solid_cache"
gem "solid_queue"
gem "sqlite3", ">= 2.1"
gem "thruster"
gem "brakeman"
gem "byebug"
gem "kamal"
gem "listen", "~> 3.2"
gem "puma", "~> 6.0"
gem "rails", "~> 8.1.0"
gem "rubocop-rails-omakase"
gem "solid_queue"
gem "spring", "!= 2.1.1"
gem "spring-watcher-listen", "~> 2.0.0"
gem "sqlite3", ">= 2.1"
gem "thruster"
gem "minitest", "~> 5.27"

Copilot uses AI. Check for mistakes.
end
1 change: 1 addition & 0 deletions gemfiles/rails6.1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,6 @@ gem "rails", "~> 6.1.0", ">= 6.1.0.0"
gem "spring", "!= 2.1.1"
gem "spring-watcher-listen", "~> 2.0.0"
gem "sqlite3", "~> 1.4"
gem "minitest", "~> 5.27"

gemspec name: "factory_bot_rails", path: "../"
1 change: 1 addition & 0 deletions gemfiles/rails7.0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,6 @@ gem "rails", "~> 7.0.1", ">= 7.0.1"
gem "spring", "!= 2.1.1"
gem "spring-watcher-listen", "~> 2.0.0"
gem "sqlite3", "~> 1.4"
gem "minitest", "~> 5.27"

gemspec name: "factory_bot_rails", path: "../"
1 change: 1 addition & 0 deletions gemfiles/rails7.1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@ gem "spring", "!= 2.1.1"
gem "spring-watcher-listen", "~> 2.0.0"
gem "sqlite3", "~> 1.4"
gem "standard"
gem "minitest", "~> 5.27"

gemspec name: "factory_bot_rails", path: "../"
1 change: 1 addition & 0 deletions gemfiles/rails7.2.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@ gem "spring", "!= 2.1.1"
gem "spring-watcher-listen", "~> 2.0.0"
gem "sqlite3", "~> 1.4"
gem "standard"
gem "minitest", "~> 5.27"

gemspec name: "factory_bot_rails", path: "../"
1 change: 1 addition & 0 deletions gemfiles/rails8.0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,6 @@ gem "spring-watcher-listen", "~> 2.0.0"
gem "sqlite3", ">= 2.1"
gem "standard"
gem "thruster"
gem "minitest", "~> 5.27"

gemspec name: "factory_bot_rails", path: "../"
18 changes: 18 additions & 0 deletions gemfiles/rails8.1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "bcrypt"
gem "brakeman"
gem "bundler-audit"
gem "kamal"
gem "minitest", "~> 5.27"
gem "puma"
gem "rails", "~> 8.1.0"
gem "rubocop-rails-omakase"
gem "solid_cache"
gem "solid_queue"
gem "sqlite3", ">= 2.1"
gem "thruster"

Copy link

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated gemfile appears to be missing several gems that should be automatically included from the gemspec development dependencies. All other Rails version gemfiles (e.g., rails8.0.gemfile, rails7.2.gemfile) explicitly list these gems:

  • appraisal
  • aruba
  • cucumber
  • rake
  • rspec-rails
  • standard

Additionally, gems like bcrypt and solid_cache that appear in rails8.0.gemfile are also missing. This suggests the gemfile may not have been generated correctly using the appraisal generate command, or there's an issue with the Appraisal gem's generation process for this configuration.

Suggested change
gem "appraisal"
gem "aruba"
gem "cucumber"
gem "rake"
gem "rspec-rails"
gem "standard"

Copilot uses AI. Check for mistakes.
gemspec name: "factory_bot_rails", path: "../"