Skip to content

Provide alternative solutions #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatheusRich merged 2 commits into from
Jun 10, 2025
Merged

Provide alternative solutions #762

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02b8051
Add guidance on providing alternative solutions in reviews
MatheusRich Jun 6, 2025
21e86e8
Links!
MatheusRich Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions code-review/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ Watch a presentation that covers this material from [Derek Prior at RailsConf 20
- **Be explicit**
- Remember people don't always understand your intentions online.

- **When disagreeing, provide alternative solutions**
- Don't [simply reject an idea][dont-mcblock-me]. [Explain your reasoning](https://thoughtbot.com/blog/don-t-review-prs-like-a-space-wizard) and [suggest alternative approaches](https://github.com/thoughtbot/guides/pull/762#discussion_r2135772338).

- **Be humble**
- "I'm not sure - let's look it up."

Expand Down Expand Up @@ -133,3 +136,4 @@ This helps us have more meaningful conversations on PRs rather than debating per
[challenging to convey emotion and intention online]: https://thoughtbot.com/blog/empathy-online
[using labels]: https://conventionalcomments.org
[standard]: https://github.com/testdouble/standard
[dont-mcblock-me]: https://www.schneems.com/2025/06/03/dont-mcblock-me