Skip to content

Commit

Permalink
Update test matrix to supported Ruby + Rails versions (#337)
Browse files Browse the repository at this point in the history
This aligns high_voltage to supported Ruby and Rails versions with the following changes:

- Removes Rails 6.x support
- Adds Rails 7.2 and Rails 8.0 to the test matrix
- Bumps minimum supported Ruby version to 3.1
  • Loading branch information
luizkowalski authored Feb 8, 2025
1 parent 6c55297 commit 49308ce
Show file tree
Hide file tree
Showing 8 changed files with 35 additions and 19 deletions.
25 changes: 14 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,22 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: ['3.0', '3.1', '3.2', '3.3']
gemfile: ['rails_6.0','rails_6.1','rails_7.0', 'rails_7.1']
ruby-version: ['3.1', '3.2', '3.3', '3.4']
gemfile: ['rails_7.0', 'rails_7.1', 'rails_7.2', 'rails_8.0']
exclude:
- ruby-version: '3.1'
gemfile: 'rails_8.0'
runs-on: ubuntu-latest
env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
name: Specs - Ruby ${{ matrix.ruby-version }} with ${{ matrix.gemfile }}
steps:
- uses: actions/checkout@v4
- name: Set up Ruby ${{ matrix.ruby-version }} with ${{ matrix.gemfile }}
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true
rubygems: default
- name: Run specs
run: bundle exec rake spec
- uses: actions/checkout@v4
- name: Set up Ruby ${{ matrix.ruby-version }} with ${{ matrix.gemfile }}
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
bundler-cache: true
rubygems: default
- name: Run specs
run: bundle exec rake spec
11 changes: 9 additions & 2 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,13 +1,20 @@
rails_versions = %w(
6.0
6.1
7.0
7.1
7.2
8.0
)

rails_versions.each do |version|
appraise "rails_#{version}" do
gem "rails", "~> #{version}.0"
if version == "7.0"
gem "benchmark"
gem "bigdecimal"
gem "drb"
gem "logger"
gem "mutex_m"
end
gem "rails-controller-testing"
end
end
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -141,12 +141,12 @@ PLATFORMS
ruby

DEPENDENCIES
activesupport (>= 6.0)
activesupport (>= 7.0)
appraisal
capybara
high_voltage!
pry
rspec-rails (~> 5.1.2)

BUNDLED WITH
2.2.33
2.6.3
5 changes: 5 additions & 0 deletions gemfiles/rails_7.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
source "https://rubygems.org"

gem "rails", "~> 7.0.0"
gem "benchmark"
gem "bigdecimal"
gem "drb"
gem "logger"
gem "mutex_m"
gem "rails-controller-testing"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/rails_6.0.gemfile → gemfiles/rails_7.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source "https://rubygems.org"

gem "rails", "~> 6.0.0"
gem "rails", "~> 7.2.0"
gem "rails-controller-testing"

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/rails_6.1.gemfile → gemfiles/rails_8.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source "https://rubygems.org"

gem "rails", "~> 6.1.0"
gem "rails", "~> 8.0.0"
gem "rails-controller-testing"

gemspec path: "../"
4 changes: 2 additions & 2 deletions high_voltage.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ Gem::Specification.new do |s|
s.test_files = []
s.require_paths = ["lib"]

s.required_ruby_version = '>= 3.0'
s.add_development_dependency('activesupport', '>= 6.0')
s.required_ruby_version = '>= 3.1'
s.add_development_dependency('activesupport', '>= 7.0')
s.add_development_dependency('appraisal')
s.add_development_dependency('capybara')
s.add_development_dependency('pry')
Expand Down
1 change: 1 addition & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
ENV["RAILS_ENV"] = "test"

require "pry"
require "logger"
require "active_model/railtie"
require "action_controller/railtie"
require "action_view/railtie"
Expand Down

0 comments on commit 49308ce

Please sign in to comment.