fix: require ruby_llm >= 1.8.0 via OTel compatible block#25
Open
oleksii-leonov wants to merge 1 commit into
Open
fix: require ruby_llm >= 1.8.0 via OTel compatible block#25oleksii-leonov wants to merge 1 commit into
compatible block#25oleksii-leonov wants to merge 1 commit into
Conversation
oleksii-leonov
force-pushed
the
chore/require-ruby_llm-1.8.0
branch
from
0e7c749 to
c9b9988
Compare
Make the requirement explicit via the standard OTel instrumentation pattern: a `compatible` block that returns false when the loaded `ruby_llm` version is below the pin (mirrors what httpx, http, http_client do in opentelemetry-ruby-contrib). When the block returns false, OpenTelemetry::Instrumentation::Base silently skips installing the instrumentation — no raise, no patch application — so apps on older `ruby_llm` continue to function without the OTel traces (and without a hard crash). Note: `gem "rspec-mocks"` test dependency added to use `stub_const`. This is aligned with other instrumentation gems in opentelemetry-ruby-contrib.
oleksii-leonov
force-pushed
the
chore/require-ruby_llm-1.8.0
branch
from
c9b9988 to
e61dc26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the requirement explicit via the standard OTel instrumentation pattern: a
compatibleblock that returns false when the loadedruby_llmversion is below the pin (mirrors what httpx, http, http_client do inopentelemetry-ruby-contrib).When the block returns false,
OpenTelemetry::Instrumentation::Basesilently skips installing the instrumentation — no raise, no patch application — so apps on olderruby_llmcontinue to function without the OTel traces (and without a hard crash).