Update to Rails 8.0.3 #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdnewmanbot
commented
Oct 22, 2025
| # Show full error reports. | ||
| config.consider_all_requests_local = true | ||
|
|
||
| config.hosts << ENV["NGROK_DOMAIN"] unless ENV["NGROK_DOMAIN"].blank? |
Author
There was a problem hiding this comment.
I left this as it was, but not sure if we still use ngrok (or if left over from double-up)
There was a problem hiding this comment.
I think this is for providing a url to slack to test out the integration. I've never used it but it's probably useful
brian-penguin
approved these changes
Oct 23, 2025
| # Show full error reports. | ||
| config.consider_all_requests_local = true | ||
|
|
||
| config.hosts << ENV["NGROK_DOMAIN"] unless ENV["NGROK_DOMAIN"].blank? |
There was a problem hiding this comment.
I think this is for providing a url to slack to test out the integration. I've never used it but it's probably useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplecovsupport for RSpec_helpersThis should help ensure project can continue to work with most recent Heroku and Postgres versions.