fix: with_high_message expects a custom validation message too#1623
Open
freesteph wants to merge 1 commit into
Open
fix: with_high_message expects a custom validation message too#1623freesteph wants to merge 1 commit into
freesteph wants to merge 1 commit into
Conversation
The only impact being in the generated documentation (via description_clauses_for_qualifiers): before: > is expected to validate that Y lies inside the range R after > is expected to validate that X lies inside the range R producing a custom validation error on failure As with_low_message already does.
matsales28
reviewed
Mar 22, 2024
Member
matsales28
left a comment
There was a problem hiding this comment.
Do you mind adding a spec to cover this case?
I think you can do something similar to the one on spec/unit/shoulda/matchers/active_model/validate_numericaly_of_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only impact being in the generated documentation (via description_clauses_for_qualifiers):
before:
after
As with_low_message already does.