Add styling for header/footer#2827
Merged
thoughtbot-summer merged 6 commits intoNov 26, 2025
Merged
Conversation
achen178
reviewed
Nov 25, 2025
Contributor
There was a problem hiding this comment.
Great work! I have a few notes, but I think some of these comments can come in a second pass:
- Added a suggestion to change link color to be darker for accessibility.
- Upcase Classic link should have an icon next to it to indicate it's essentially "leaving" the current site
- Mobile responsiveness is a little wonky (can do this in a second pass)
- CSS properties should ideally be alphabetized — I have a plugin for this so I can also help with doing so in a second PR
Let me know what you think. I'm happy to approve this PR for now and create a new one for the comments.
So that it's not read aloud to screen readers
Co-authored-by: Alex Chen <hey.acchen@gmail.com>
thoughtbot-summer
force-pushed
the
marketing-redesign-header-footer-full-styling
branch
from
312c1ca to
c4f8a13
Compare
thoughtbot-summer
deleted the
marketing-redesign-header-footer-full-styling
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Trello: Upcase: Full content/styling.