fix: Add Cross-Origin-Opener-Policy header for Google Sign-In #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds 'same-origin-allow-popups' COOP header to webpack dev server config to fix Google OneTap Sign-In popup being blocked. Fixes thoughtworks#346
There was a problem hiding this comment.
Pull request overview
Adds a development-only Cross-Origin-Opener-Policy: same-origin-allow-popups header to the webpack dev server to prevent Google OneTap Sign-In popups from being blocked (Fixes #346).
Changes:
- Configure
devServer.headersinwebpack.dev.jsto send the COOP header during local development.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the \Cross-Origin-Opener-Policy: same-origin-allow-popups\ header to the webpack dev server configuration to fix Google OneTap Sign-In popup being blocked.
Changes
Testing
pm run dev\
Fixes #346