ENG-515: add rescue bank feat#920
Open
RobertoMSousa wants to merge 1 commit intothreshold-network:mainfrom
Open
ENG-515: add rescue bank feat#920RobertoMSousa wants to merge 1 commit intothreshold-network:mainfrom
RobertoMSousa wants to merge 1 commit intothreshold-network:mainfrom
Conversation
RobertoMSousa
requested review from
Shadowfiend,
lrsaturnino,
lukasz-zimnoch,
nkuba,
pdyraga and
piotr-roslaniec
as code owners
RobertoMSousa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a cross-chain redemption fails on L1 (for example due to a guardian veto or a timeout), the refunded amount is sent back to the L1BTCRedeemerWormhole contract’s Bank balance. Until now, there was no way to move those funds out again, which meant refunds could get stuck unless we shipped a contract upgrade.
What this PR does
This PR adds a small, controlled escape hatch to handle these cases cleanly:
• Introduces a recoveryAddress dedicated to refund recovery
• Adds setRecoveryAddress(address) (owner-only) with basic safety checks and an event
• Adds rescueBankBalance(address recipient, uint256 amount) (owner-only), which:
• only allows transfers to the configured recoveryAddress
• moves funds using bank.transferBalance
• emits an event for transparency and auditability
LInear link: https://linear.app/tlabz/issue/ENG-515/add-refund-recovery-escape-hatch-to-l1btcredeemerwormhole-bank-balance