Remove Sei support - #998
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR removes the Sei cross-chain implementation, deployment tooling, configuration, artifacts, and TypeScript exports. Solidity tests and NTT documentation are updated to use generic destination-chain terminology and Ethereum Sepolia examples. ChangesSei integration removal
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mswilkison
marked this pull request as ready for review
July 14, 2026 20:19
mswilkison
requested review from
Shadowfiend,
lrsaturnino,
lukasz-zimnoch,
nkuba,
pdyraga and
piotr-roslaniec
as code owners
July 14, 2026 20:19
piotr-roslaniec
approved these changes
Jul 15, 2026
piotr-roslaniec
left a comment
piotr-roslaniec
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Clean Sei removal; verified via multi-agent review (correctness/security/contrarian/docs) plus a docs-example fix. CI green.
mswilkison
added a commit
that referenced
this pull request
Jul 16, 2026
Retain the Sei removals from #998 while preserving the Wormhole executor guardrails.
piotr-roslaniec
pushed a commit
that referenced
this pull request
Jul 20, 2026
Reconciles the NTT migration branch with main. main's only change since the merge-base is the Sei removal (#998), which this branch had already applied via its fixed-destination NTT redesign; all conflicts resolved in favor of this branch's redesign. Resulting tree is identical to the branch tip plus removal of the residual cross-chain/sei artifacts.
mswilkison
added a commit
that referenced
this pull request
Jul 25, 2026
Resolves the conflict with `Remove Sei support (#998)`, the single commit main had gained since this branch forked. Sei source, tests and generated pages take main's deletion. This branch had only touched them incidentally, adding the repo-wide `supportsTaprootDeposits()` interface method that every chain implementation gained; with the implementation gone there is nothing left to implement it. No dangling reference to the module remains. `typescript/api-reference` is regenerated with typedoc rather than hand-merged, since it is build output: three pages conflicted on content and six Sei pages are dropped. SDK suite: 874 passing, 0 failing.
mswilkison
added a commit
that referenced
this pull request
Jul 25, 2026
Resolves the conflict with `Remove Sei support (#998)`, the single commit main had gained since this branch forked. Sei source, tests and generated pages take main's deletion. This branch had only touched them incidentally, adding the repo-wide `supportsTaprootDeposits()` interface method that every chain implementation gained; with the implementation gone there is nothing left to implement it. No dangling reference to the module remains. `typescript/api-reference` is regenerated with typedoc rather than hand-merged, since it is build output: three pages conflicted on content and six Sei pages are dropped. SDK suite: 874 passing, 0 failing.
piotr-roslaniec
added a commit
that referenced
this pull request
Aug 31, 2026
Reconciles the NTT migration branch with main. main's only change since the merge-base is the Sei removal (#998), which this branch had already applied via its fixed-destination NTT redesign; all conflicts resolved in favor of this branch's redesign. Resulting tree is identical to the branch tip plus removal of the residual cross-chain/sei artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run buildfromsolidityyarn buildfromtypescriptusing Yarn 4yarn test --grep "NTT Utilities"fromtypescriptunder Node 18: 20 passingprovider.init is not a function; a clean Yarn 4 reinstall was blocked locally by DNS resolution forregistry.yarnpkg.comSummary by CodeRabbit