Fix PR workflow perms#47
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes the explicit GitHub Actions job-level File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/container-pr.yml" line_range="96-97" />
<code_context>
build:
needs: resolve
+
+ permissions:
+ packages: write
+
uses: ./.github/workflows/container.yml
</code_context>
<issue_to_address>
**🚨 issue (security):** Revisit whether `packages: write` is the minimum required permission for this job.
This broad permission increases the blast radius if the workflow is abused. If the underlying `container.yml` only pulls images, `packages: read` should be sufficient. If write access is required (e.g., publishing images), ensure this job only runs in trusted contexts (no `pull_request_target`) and isn’t reused in workflows that shouldn’t have package write access.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
The `container` workflow does not need the permission, we use a PAT for writing to the registry. Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
5d47fdf to
7f775ac
Compare
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The PR description says the container PR workflow should request write access to packages, but the diff removes
permissions: packages: writeentirely—please reconcile the intent with the actual change so it's clear whether this permission is still needed anywhere. - If the PAT is now solely responsible for registry access, consider adding a brief comment in the workflow near the login/push step indicating that permissions are intentionally omitted and PAT scopes are relied on instead, to avoid future confusion.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR description says the container PR workflow should request write access to packages, but the diff removes `permissions: packages: write` entirely—please reconcile the intent with the actual change so it's clear whether this permission is still needed anywhere.
- If the PAT is now solely responsible for registry access, consider adding a brief comment in the workflow near the login/push step indicating that permissions are intentionally omitted and PAT scopes are relied on instead, to avoid future confusion.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
containerworkflow does not need permissions, we use a PAT to push to registry.Summary by Sourcery
CI:
Summary by Sourcery
CI: