Skip to content

Adjust markdownlint to use correct rule name#48

Merged
thrix merged 1 commit into
mainfrom
fix-markdown-lint
May 22, 2026
Merged

Adjust markdownlint to use correct rule name#48
thrix merged 1 commit into
mainfrom
fix-markdown-lint

Conversation

@thrix

@thrix thrix commented May 22, 2026

Copy link
Copy Markdown
Owner

This recently changed and broke the check.

Summary by Sourcery

Build:

  • Switch markdownlint hook arguments and dependency from sentences-per-line to markdownlint-sentences-per-line to align with upstream changes.

This recently changed and broke the check.

Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
@sourcery-ai

sourcery-ai Bot commented May 22, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update pre-commit markdownlint hook configuration to use the new, correct rule and dependency name for the sentences-per-line rule so the check runs successfully again.

File-Level Changes

Change Details Files
Update markdownlint hook rule and dependency names to the new identifier so the pre-commit check no longer fails.
  • Change the rule argument passed to markdownlint from the old sentences-per-line identifier to markdownlint-sentences-per-line.
  • Update the additional_dependencies entry to install markdownlint-sentences-per-line instead of the old sentences-per-line package.
.pre-commit-config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@thrix

thrix commented May 22, 2026

Copy link
Copy Markdown
Owner Author

Containers do not build as the ghcr token expired, fixed

@thrix thrix merged commit d068c64 into main May 22, 2026
7 of 11 checks passed
@thrix thrix deleted the fix-markdown-lint branch May 22, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant