fix: prevent direct traffic leaks during profile transitions - #1768
Open
4RH1T3CT0R7 wants to merge 5 commits into
Open
fix: prevent direct traffic leaks during profile transitions#17684RH1T3CT0R7 wants to merge 5 commits into
4RH1T3CT0R7 wants to merge 5 commits into
Conversation
Classify routing-profile outbounds and every chain hop while collecting dependencies. This keeps the fail-closed policy explicit where these additional egress paths enter the build and protects against later build-order changes bypassing shared chain validation. Also clarify that the rejection applies to profiles selected by routing rules.
Mahdi-zarei
force-pushed
the
dev
branch
2 times, most recently
from
August 17, 2026 20:10
9988348 to
7d96d9e
Compare
Member
|
These changes are too intrusive and hard to maintain, i need more time to review and see if such a feature as you have proposed is feasible to have. |
Contributor
Author
I can break this down into several logical parts if this will help |
Member
No not really, I will try to get back to you as soon as i can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing profile switch path stops the current core before starting the next one. Closing the core also removes the TUN adapter, routes, DNS handling, and sing-tun's dynamic WFP filters. During that gap, Windows can use the physical default route again.
This adds an opt-in Windows kill switch in Tun Settings. It installs fail-closed Windows Filtering Platform policy before any profile is torn down and keeps direct traffic blocked while Throne is connecting, switching, reconnecting, disconnected, or in an error state. The setting is disabled by default.
Implementation
Fixes #1611