Fix Windows compilation issues for PyTorch 2.10.0#345
Open
gzsiang wants to merge 1 commit intothu-ml:mainfrom
Open
Fix Windows compilation issues for PyTorch 2.10.0#345gzsiang wants to merge 1 commit intothu-ml:mainfrom
gzsiang wants to merge 1 commit intothu-ml:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows compilation issues for PyTorch 2.10.0
This PR resolves several critical issues when compiling SageAttention on Windows systems:
stdnamespace conflict by adding/permissive-MSVC compiler flagc10::MessageLoggerconstructor compatibility issueTested environment:
These modifications don't affect Linux/macOS builds while significantly improving the Windows user experience. Many Windows users will benefit from this fix as Windows represents approximately 25-30% of PyTorch users according to official statistics.