fix: restore parameters on TRPO line search failure#1287
Open
Mr-Neutr0n wants to merge 1 commit intothu-ml:masterfrom
Open
fix: restore parameters on TRPO line search failure#1287Mr-Neutr0n wants to merge 1 commit intothu-ml:masterfrom
Mr-Neutr0n wants to merge 1 commit intothu-ml:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When the TRPO line search fails to find a step that satisfies the KL constraint, the original policy parameters are not restored. This leaves the policy with an untested update that violates the trust region.
Fix
Added parameter restoration to the line search fallback path.