Skip to content

License#18

Merged
thumbrise merged 2 commits into
mainfrom
10-need-license
Mar 18, 2026
Merged

License#18
thumbrise merged 2 commits into
mainfrom
10-need-license

Conversation

@thumbrise

@thumbrise thumbrise commented Mar 18, 2026

Copy link
Copy Markdown
Owner

PR #18: License

Summary

Adds Apache 2.0 licensing to the project with automated enforcement tooling and CI updates.

Changes

1. License File & Copyright Headers

  • Added standard Apache 2.0 LICENSE file at repo root.
  • Prepended Copyright 2026 thumbrise Apache 2.0 header to all .go and .js source files (9 files).

2. License Enforcement Tooling (license-eye)

  • Added github.com/apache/skywalking-eyes as a Go tool dependency (go.mod).
  • New .licenserc.yaml configures license-eye to:
    • Check Apache 2.0 headers on **/*.go, **/*.js, **/*.ts, **/*.sh.
    • Ignore generated/config files (*.yaml, *.md, go.mod, go.sum, etc.).
    • Scan dependency licenses against go.mod.
  • New license task in Taskfile.yaml runs license-eye header fix for local auto-fixing.

3. CI Restructuring (.github/workflows/ci.yml)

  • Lint job: Replaced golangci/golangci-lint-action@v9 with manual golangci-lint install + task lint.
    • task lint now runs both golangci-lint and license-eye (dependency check + header check).
    • Note: Lost only-new-issues: true behavior — all existing lint issues will now be reported.
  • Both jobs: Replaced unofficial rnorton5432/setup-task@v1 with official go-task/setup-task@v1.

4. Minor Test Refactor (signal/trace/composite_sampler_test.go)

  • Simplified a negated compound condition using De Morgan's law:
    • Before: !(Drop < RecordOnly && RecordOnly < RecordAndSample)
    • After: Drop >= RecordOnly || RecordOnly >= RecordAndSample

@thumbrise thumbrise linked an issue Mar 18, 2026 that may be closed by this pull request
@thumbrise thumbrise changed the title 10 need license #10 need license Mar 18, 2026
@thumbrise thumbrise changed the title #10 need license License Mar 18, 2026
@thumbrise thumbrise marked this pull request as ready for review March 18, 2026 18:38

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

devin-ai-integration[bot]

This comment was marked as resolved.

Additionaly, only-new-issues behaviour for golangci-lint intentionaly disabled to strictless
@thumbrise thumbrise merged commit 0f0b0c4 into main Mar 18, 2026
7 checks passed
@thumbrise thumbrise deleted the 10-need-license branch March 18, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need license

1 participant