Fix issue #8: CompositeSampler allows later samplers to upgrade RecordOnly to RecordAndSample#9
Closed
thumbrise wants to merge 2 commits into
Closed
Fix issue #8: CompositeSampler allows later samplers to upgrade RecordOnly to RecordAndSample#9thumbrise wants to merge 2 commits into
thumbrise wants to merge 2 commits into
Conversation
Owner
Author
|
@openhands-agent Run lint and add godoc to sampler about restrict strategy |
…dOnly to RecordAndSample
thumbrise
force-pushed
the
openhands-fix-issue-8
branch
from
584bcac to
66938a5
Compare
Owner
Author
…grade RecordOnly to RecordAndSample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #8.
The new logic iterates through the samplers and maintains a
finalResult. If any sampler returnsDrop, that result is immediately returned, preserving the short-circuiting behavior for drops. If a sampler returnsRecordOnly, this is noted, andfinalResultis updated toRecordOnly. If a sampler returnsRecordAndSample, it only updatesfinalResultifRecordOnlyhas not yet been encountered. This ensures that if any sampler returnsRecordOnly, the final decision will beRecordOnly, effectively implementing an AND-like behavior where any sampler can restrict the decision (toRecordOnlyorDrop), but not upgrade it.