refactor(message-item): update MessageItem Composable API to support configurable layout and interactions#10695
Conversation
github-actions
Bot
added
the
tb-team
rafaeltonholo
force-pushed
the
refactor/10554/message-item-composable-api-changes
branch
2 times, most recently
from
9802c03 to
db4cb0a
Compare
|
Could you rebase this with main? Unless I'm mistaken, looks like there are some duplicates form the other PR and it might help see what changed here, specifically, better. |
…em` in favour of a unified, configurable `MessageItem` organism.
…rable layout and interactions
rafaeltonholo
force-pushed
the
refactor/10554/message-item-composable-api-changes
branch
from
db4cb0a to
451e87e
Compare
|
Missing report label. Set exactly one of: |
Done |
|
Missing report label. Set exactly one of: |
rafaeltonholo
added
the
report: exclude
|
It seems like the leading items have been deleted from the message item view. Was this intentional? |
| onAvatarClick: () -> Unit = {}, | ||
| onTrailingClick: (MessageItemTrailingElement) -> Unit = {}, | ||
| ) { | ||
| // NOTE: The current implementation changes are just to fix the compilation errors the API changes have caused. |
There was a problem hiding this comment.
On one hand, I do hate the idea of merging something into main that breaks it. On the other hand, I get where this is coming from and I assume that one of the other PRs adds it back?
There was a problem hiding this comment.
On one hand, I do hate the idea of merging something into main that breaks it. On the other hand, I get where this is coming from and I assume that one of the other PRs adds it back?
This Composable is guarded by a feature flag, and users won't see any difference when merging this, but I understand your point.
The Leading items composable was reworked in the PR #10680, which was split by this one, making it more self-contained. For that reason, on this one, it was required to remove it temporarily.
There was a problem hiding this comment.
Yes. The correct implementation of the Leading items is on #10680 |
rafaeltonholo
deleted the
refactor/10554/message-item-composable-api-changes
branch
2 participants
Part of #10554.
Depends on #10685.
Split of #10680.
ActiveMessageItemandJunkMessageItemin favour of a unified, configurableMessageItemorganism.