fix(proguard): update rules to preserve enum constants and collection interfaces for Moshi#10698
Merged
rafaeltonholo merged 1 commit intoMar 17, 2026
Conversation
… interfaces for Moshi
rafaeltonholo
added a commit
to rafaeltonholo/thunderbird-android
that referenced
this pull request
Mar 17, 2026
… interfaces for Moshi (thunderbird#10698)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #10697.
This pull request updates the ProGuard rules for both the K-9 Mail and Thunderbird Android apps to ensure compatibility with Moshi's JSON serialization/deserialization, especially when using R8 optimizations. The changes prevent R8 from stripping necessary enum constants and class structures that Moshi relies on for reflective access.
Changes
net.thunderbird.core.common.mail.Flagenum, preventing R8 from stripping enum constants required by Moshi'sEnumJsonAdapterfor JSON deserialization.com.fsck.k9.controller.MessagingControllerCommands, ensuring Moshi can access collection types via reflection and is not broken by R8's class rewriting.Testing
fossRelease, Thunderbirdfoss/fullDaily,foss/fullBeta,foss/fullRelease