fix(TokenCompleteTextView): handle missing generic type signature for R8/ProGuard compatibility#10711
Merged
rafaeltonholo merged 1 commit intoMar 18, 2026
Conversation
… R8/ProGuard compatibility
github-actions
Bot
added
the
tb-team
rafaeltonholo
requested review from
wmontwe
and removed request for
jbott-tbird
rafaeltonholo
added a commit
to rafaeltonholo/thunderbird-android
that referenced
this pull request
Mar 18, 2026
… R8/ProGuard compatibility (thunderbird#10711)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10710.
Description
R8 is now stripping the generic Signature attribute from some classes, which caused the
getGenericSuperclass()to return a rawClassinstead of the expectedParameterizedType.To fix the runtime crash issue, we now check if the generic superclass is an instance of
ParameterizedTypebefore getting the type arguments. Otherwise, we fall back toObject.class, so it triggers theSerializablepath when saving the class to the Bundle.Screen recording:
Screen.Recording.2026-03-18.at.9.46.42.AM.mp4