Skip to content

refactor: mail to kotlin - part 1#11013

Merged
wmontwe merged 13 commits into
thunderbird:mainfrom
wmontwe:refactor-mail-to-kotlin-part1
May 21, 2026
Merged

refactor: mail to kotlin - part 1#11013
wmontwe merged 13 commits into
thunderbird:mainfrom
wmontwe:refactor-mail-to-kotlin-part1

Conversation

@wmontwe
Copy link
Copy Markdown
Member

@wmontwe wmontwe commented May 18, 2026

This migrates several IMAP protocol utility and handler classes from Java to Kotlin. It also modernizes some internal APIs and simplifies imap utility usage.

  • Converted ImapCommandSplitter, ImapUtility, ImapResponseCallback, and UntaggedHandler from Java to Kotlin.
  • Updated usages of utility methods (e.g., ImapUtility.join and ImapUtility.getLastResponse) to use Kotlin collection functions (joinToString, last).

wmontwe added 13 commits May 18, 2026 16:27
(cherry picked from commit b499482a72356e81c39a2dd4e5733a8b09c45537)
(cherry picked from commit 8bab7e20126434e84e127eee4e8a9c2c8bca4448)
(cherry picked from commit dd0d9b5caa40cadd05bfb656507d6e6071b5d160)
(cherry picked from commit a4ccfc3cad7a29fb7fab5545ade535f7f8dbe9df)
(cherry picked from commit 0fe7c55c7a21e9a1ee22ecfe1c69912d444e32dd)
(cherry picked from commit 18c259683546349f8abf65aa1bb469fb9e32a5f8)
(cherry picked from commit 64617ad866cccdb61715c11666261b46b79c13d2)
(cherry picked from commit cf8d03f0c0074b7e27420f48b94475c69d25ecdb)

# Conflicts:
#	mail/protocols/imap/src/main/java/com/fsck/k9/mail/store/imap/ImapUtility.kt
@wmontwe wmontwe requested a review from a team as a code owner May 18, 2026 15:02
@wmontwe wmontwe requested a review from jbott-tbird May 18, 2026 15:02
@github-actions github-actions Bot added the tb-team Tasks and features handled by project maintainers label May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

Validation Passed: All report and feature-flag labels are correctly set.

@wmontwe wmontwe requested review from dani-zilla and removed request for jbott-tbird May 18, 2026 15:03
@wmontwe wmontwe assigned dani-zilla and unassigned jbott-tbird May 18, 2026
@wmontwe wmontwe added the report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). label May 18, 2026
Copy link
Copy Markdown
Contributor

@dani-zilla dani-zilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmontwe wmontwe merged commit 99df0b8 into thunderbird:main May 21, 2026
20 of 21 checks passed
@wmontwe wmontwe deleted the refactor-mail-to-kotlin-part1 branch May 21, 2026 13:02
@thunderbird-botmobile thunderbird-botmobile Bot added this to the Thunderbird 20 milestone May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). tb-team Tasks and features handled by project maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants