Skip to content

K9WebViewClient: log WebView main-frame load errors #11030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmontwe merged 2 commits into from
May 26, 2026
+10 −0
Merged

K9WebViewClient: log WebView main-frame load errors #11030

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
477697a
K9WebViewClient: log WebView main-frame load errors
jim-daf May 20, 2026
5ad43d2
Suppress detekt TooManyFunctions on K9WebViewClient
jim-daf May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions legacy/ui/legacy/src/main/java/com/fsck/k9/view/K9WebViewClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import android.content.Intent
import android.net.Uri
import android.os.Build
import android.provider.Browser
import android.webkit.WebResourceError
import android.webkit.WebResourceRequest
import android.webkit.WebResourceResponse
import android.webkit.WebView
Expand All @@ -21,6 +22,7 @@ import net.thunderbird.core.logging.legacy.Log
/**
* [WebViewClient] that intercepts requests for `cid:` URIs to load the respective body part.
*/
@Suppress("TooManyFunctions")
class K9WebViewClient(
private val clipboardManager: ClipboardManager,
private val attachmentResolver: AttachmentResolver?,
Expand Down Expand Up @@ -120,6 +122,14 @@ class K9WebViewClient(
onPageFinishedListener?.onPageFinished()
}

@RequiresApi(Build.VERSION_CODES.M)
override fun onReceivedError(view: WebView, request: WebResourceRequest, error: WebResourceError) {
super.onReceivedError(view, request, error)
if (request.isForMainFrame) {
Log.d("Message WebView load error: %d %s for %s", error.errorCode, error.description, request.url)
}
}

companion object {
private const val CID_SCHEME = "cid"
private const val FILE_SCHEME = "file"
Expand Down
Loading