Skip to content

fix: printed header uses US date/time format rather than the device locale#11129

Merged
dani-zilla merged 1 commit into
thunderbird:mainfrom
mohitsatr:locale-datetime
Jun 18, 2026
Merged

fix: printed header uses US date/time format rather than the device locale#11129
dani-zilla merged 1 commit into
thunderbird:mainfrom
mohitsatr:locale-datetime

Conversation

@mohitsatr

Copy link
Copy Markdown
Contributor

Fixes #11109

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Validation Passed: All report and feature-flag labels are correctly set.

@rafaeltonholo rafaeltonholo added the report: include Include changes in user-facing reports. label Jun 11, 2026
@AvikMakwana

Copy link
Copy Markdown

Thanks for working on this.

I had also investigated #11109 locally and reached the same production fix: replacing the hardcoded M/d/yyyy, h:mm a print-header formatter with Android’s locale-aware DateFormat.getDateFormat(context) and DateFormat.getTimeFormat(context).

I manually verified the behavior on a Motorola Edge 60 Fusion with 24-hour time enabled, using the same email in both builds:

  • Thunderbird Beta 20.0b1: Date: 6/11/26, 4:31 PM
  • Patched local build: Date: 11/06/26, 16:31

So this confirms the fix respects local date ordering and the 24-hour time preference.

I also have a small Robolectric regression test for a German region / 24-hour setup. Happy to share that patch if test coverage would be useful here.

@dani-zilla dani-zilla left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! In the future, please fill out the full PR template. However, thank you for including the ticket and for fixing this for us!

@dani-zilla dani-zilla merged commit cecb0f4 into thunderbird:main Jun 18, 2026
19 of 20 checks passed
@thunderbird-botmobile thunderbird-botmobile Bot added this to the Thunderbird 22 milestone Jun 18, 2026
@antroyd

antroyd commented Jun 18, 2026

Copy link
Copy Markdown

Thanks for fixing it.
Which will be the version / beta this fix will be implemented first?

@mohitsatr mohitsatr deleted the locale-datetime branch June 19, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: include Include changes in user-facing reports.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Printing: Date not reflecting locales

5 participants