feat: remove gmail prefix in folder structure

[shamim-emon]

• Fixes Special case Gmail and hide [Gmail] / [Google Mail] in the folder structure #9134

[asoucar]

LGTM thank you!

[kewisch]

Is this something we could rather change in the folder modeling code to just skip the [Gmail] folder completely, rather than just formatting away the name?

Also note that sometimes the folder is called [Google Mail], and we should only be doing this on gmail based accounts.

[asoucar]

Is this something we could rather change in the folder modeling code to just skip the [Gmail] folder completely, rather than just formatting away the name?

Also note that sometimes the folder is called [Google Mail], and we should only be doing this on gmail based accounts.

Its my (admittedly imperfect) understanding that the first section of code is doing the filtering out? Clearly it would need some additional robustness if the folder has alternate names

[asoucar]

Thank you for the update! While reviewing this again and thinking further about the problem, I think this is heading in the right direction but is starting with a fundamental gap. Right now this (and other current filtering ideas) is happening on the UI layer. Your fix would have the app attempting to update the database every time the MessageList screen is created. While the display name for a folder is a UI component, the issue is at its core an issue with the data model. That makes addressing it at the UI layer a band-aid at best.
I think your actual filter code is actually pretty comprehensive. What if we could apply it as the database was being populated? That way it only has to happen once (with perhaps a migration step for previously loaded folder structures), decoupling the data model from the UI for better separation of concerns. Potentially there would then have to be some handling for when new emails are fetched to ensure they end up in the appropriate folder too.

[shamim-emon]

Thank you for the update! While reviewing this again and thinking further about the problem, I think this is heading in the right direction but is starting with a fundamental gap. Right now this (and other current filtering ideas) is happening on the UI layer. Your fix would have the app attempting to update the database every time the MessageList screen is created. While the display name for a folder is a UI component, the issue is at its core an issue with the data model. That makes addressing it at the UI layer a band-aid at best. I think your actual filter code is actually pretty comprehensive. What if we could apply it as the database was being populated? That way it only has to happen once (with perhaps a migration step for previously loaded folder structures), decoupling the data model from the UI for better separation of concerns. Potentially there would then have to be some handling for when new emails are fetched to ensure they end up in the appropriate folder too.

@asoucar with the latest approach I'm doing following:

1. I'm removing Gmail/Google Mail prefix while folders are being created here
2. Also to deal with previously loaded folders containing Gmail/Google Mail prefix I am calling removeGmailPrefixFromFolders() when instance of CreateFolderOperations is being created like this. Calling removeGmailPrefixFromFolders() over there ensures it's called once when the instance of CreateFolderOperations is being injected.

Please let me know what do you think of this approach? Is it alright and/or anything else needed?

[asoucar]

Thanks @shamim-emon ! I think this is 90% of the way there. As it stands right now I believe this will query all db folders, whether or not it is a Gmail account. For efficiency we should only do the folder filtering for a gmail account. But otherwise I think this is a solid solution

[asoucar]

Thank your work on this!