Skip to content
This repository was archived by the owner on Feb 4, 2025. It is now read-only.

Release branch diff with upstream trunk#13

Draft
wuhuizuo wants to merge 32 commits intomasterfrom
release
Draft

Release branch diff with upstream trunk#13
wuhuizuo wants to merge 32 commits intomasterfrom
release

Conversation

@wuhuizuo
Copy link
Copy Markdown
Member

@wuhuizuo wuhuizuo commented Jan 5, 2023

Should not merge it, only for review

@wuhuizuo wuhuizuo marked this pull request as ready for review January 12, 2023 07:51
@wuhuizuo wuhuizuo marked this pull request as draft January 12, 2023 08:22
Comment thread prow/tide/tide.go Outdated
@wuhuizuo
Copy link
Copy Markdown
Member Author

/test post-test-infra-test-all

@ti-chi-bot
Copy link
Copy Markdown
Member

@wuhuizuo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-test-infra-unit-test
  • /test pull-test-infra-verify-lint

Use /test all to run all jobs.

Details

In response to this:

/test post-test-infra-test-all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Copy Markdown
Member Author

/assign lijie0123

@wuhuizuo
Copy link
Copy Markdown
Member Author

/cc @lijie0123

ignore, only for test

@wuhuizuo
Copy link
Copy Markdown
Member Author

/cc lijie0123

@wuhuizuo wuhuizuo marked this pull request as ready for review June 8, 2023 03:04
@wuhuizuo wuhuizuo marked this pull request as draft June 8, 2023 03:05
Mini256 and others added 18 commits September 11, 2023 17:06
feat: add push-tide.sh for tide release

fix: patch missing arg

fix: set prefix

fix: patch env

fix: remove edge prefix

fix

fix
* Revert "add: build tide workflow"

This reverts commit 7c8b726.

* feat(prow/config): add template function `replace` for jenkins controller

* refactor(prow/tide): move static methods to CodeReviewCommon

- and fix tests

* refactor(prow/tide): provide longer commit list by increase last limit in graphql

- from 4 to 100, it should be enough, also it make changes be easier.
- fix unit tests of prow/tide

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

* Revert "refactor(prow/tide): move static methods to CodeReviewCommon"

This reverts comment style parts of commit e725958.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

* Revert "Merge branch 'feat/add-template-function-replace' into fix/tide-custom-template"

This reverts comment changes in commit ab59468, reversing
changes made to 439f619.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
- test `.ExtractConetent` for title.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
- The plugin will add `lgtm` label in the pull request when at least
`ReviewerCount` people agreed with `/lgtm` or review approves.
- Any valid reviewer againsted, it will reset the accumulated votes and
remove the `lgtm` label if existed, the againsted vote will not be
accumulated in the next lgtm voting.

## TODO 

- [x] fix dup `lgtm` comment or review approves from same reviewer.
- [x] comment when some body delete his `/lgtm` or `/lgtm cancel`
comments for auditing.
Signed-off-by: wuhuizuo <wuhuizuo@126.com>

---------

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
- delete the `need-more-*-lgtm` label.
- update timeline comment.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
## Why

`lgtm` plugin's dup judging logic was not consider Github app bot name,
it will be `<name>[bot]` , but common user's login can not be this
format.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
…REPOS` (#29)

Some repos(which have not finished CI jobs refactoring jobs) current
need tars plugin to refresh the PR.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
It implement pr flow tasks with ChatGPT(currently we develop it with
GPT3.5 turbo and GTP4 models

---------

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
)

- skip by author
- skip by branch
- skip by pr label

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
#32)

Fixed: kubernetes#7690

Ref:
- PingCAP-QE/ee-ops#621

- Make it be fixed without massive refactoring, and not change the
behavior and approve notifies.

---------

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
ignore these formats:

- `kubernetes#1334`
- `abc kubernetes#123`
- `abc#124`
- `abc#https://org/repo/issue/1234`
- `abc#https://org/repo/issue/1234`

include those formats:
- `Fix kubernetes#123`
- `ref org/repo#1234`
- `close https://github.com/org/repo/issue/1234`

Fix ti-community-infra/tichi#1175

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo wuhuizuo force-pushed the release branch 2 times, most recently from 5e9958e to d6ed2a2 Compare September 11, 2023 09:36
`NoParentOwners` should only worked when none people got.

For an example:
```
# file sub/OWNERS
options:
  no_parent_owners: true
filters:
  "\\.yaml":
    approvers: [alice]
```

But only the file `func_test.go` changed in the PR, it should use the parent OWNERS file.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
… no parent inherit (#39)

In this case, reviewers only include sub dir's approvers and reviewers
and parent level reviewers but not include approvers in parent folder.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo <wuhuizuo@126.com>

---------

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or wuhuizuo.
/lifecycle stale

@wuhuizuo
Copy link
Copy Markdown
Member Author

wuhuizuo commented Mar 1, 2024

/remove-lifecycle stale

@wuhuizuo
Copy link
Copy Markdown
Member Author

wuhuizuo commented Mar 1, 2024

/test ?

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 1, 2024

@wuhuizuo: No presubmit jobs available for ti-community-infra/test-infra@master

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Copy Markdown
Member Author

wuhuizuo commented Mar 1, 2024

/test all

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 1, 2024

@wuhuizuo: No presubmit jobs available for ti-community-infra/test-infra@master

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

purelind added 3 commits March 1, 2024 14:54
Fix statusreconciler trigger all prs unexpectedly if f a run_if_changed
job has its regexp changed, we should check PRs against the new regexp
and only trigger it if matched the new regexp.

Signed-off-by: purelind <purelind@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or wuhuizuo.
/lifecycle stale

2 similar comments
@ti-chi-bot
Copy link
Copy Markdown
Member

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or wuhuizuo.
/lifecycle stale

@ti-chi-bot
Copy link
Copy Markdown
Member

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or wuhuizuo.
/lifecycle stale

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants