Skip to content

Improve settings and update pixelmatch #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiagofilipenunes merged 4 commits into from
Jun 5, 2025
Merged

Improve settings and update pixelmatch #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31b8d52
chore: update packages and lock versions
tiagofilipenunes Jun 5, 2025
9369d36
feat: new settings
tiagofilipenunes Jun 5, 2025
621b0dc
test: add label checks to e2e tests
tiagofilipenunes Jun 5, 2025
5d1853a
chore: bump version
tiagofilipenunes Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions e2e/diff.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,12 @@ test("Check settings page contains right header and labels", async ({
await page.goto(`chrome-extension://${extensionId}/src/popup/index.html`);
await expect(page.locator("h1")).toContainText("Settings");
expect(page.locator("form > label")).toHaveText([
"Threshold",
"Alpha",
"Diff Color",
"Alt Diff Color",
"AA Color",
"Include AA",
"Default Algo",
]);
});
5 changes: 2 additions & 3 deletions e2e/fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,11 @@ export const test = base.extend<{
context: BrowserContext;
extensionId: string;
}>({
context: async ({ headless }, use) => {
context: async ({}, use) => {
const pathToExtension = path.join(rootPath, "dist");
const context = await chromium.launchPersistentContext("", {
headless,
channel: "chromium",
args: [
...(headless ? ["--headless=new"] : []),
`--disable-extensions-except=${pathToExtension}`,
`--load-extension=${pathToExtension}`,
],
Expand Down
37 changes: 18 additions & 19 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"displayName": "Better GitHub Image Diff",
"description": "The Better Github Image Diff Chromium/Firefox extension improves the image diff experience on GitHub `Files Changed` view.",
"private": true,
"version": "1.3.2",
"version": "1.4.0",
"type": "module",
"packageManager": "pnpm@9.11.0",
"scripts": {
Expand All @@ -28,25 +28,24 @@
"e2e": "pnpm build:chromium && pnpm playwright test"
},
"devDependencies": {
"@commitlint/cli": "^19.3.0",
"@commitlint/config-conventional": "^19.2.2",
"@playwright/test": "^1.47.2",
"@types/fs-extra": "^11.0.4",
"@types/node": "^20.12.7",
"@types/pixelmatch": "^5.2.6",
"@types/webextension-polyfill": "^0.12.1",
"cross-env": "^7.0.3",
"fs-extra": "^11.2.0",
"husky": "^9.0.11",
"rimraf": "^6.0.1",
"tsx": "^4.19.0",
"typescript": "^5.2.2",
"unplugin-auto-import": "^0.18.3",
"vite": "^5.4.8",
"web-ext": "^8.3.0",
"webextension-polyfill": "^0.12.0"
"@commitlint/cli": "19.8.1",
"@commitlint/config-conventional": "19.8.1",
"@playwright/test": "1.52.0",
"@types/fs-extra": "11.0.4",
"@types/node": "22.14.0",
"@types/webextension-polyfill": "0.12.3",
"cross-env": "7.0.3",
"fs-extra": "11.3.0",
"husky": "9.1.7",
"rimraf": "6.0.1",
"tsx": "4.19.4",
"typescript": "5.8.3",
"unplugin-auto-import": "0.18.3",
"vite": "5.4.8",
"web-ext": "8.7.1",
"webextension-polyfill": "0.12.0"
},
"dependencies": {
"pixelmatch": "^5.3.0"
"pixelmatch": "7.1.0"
}
}
Loading