feat(v2.15.15): Major type updates #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagosiebler
requested changes
Mar 14, 2025
Owner
tiagosiebler
left a comment
tiagosiebler
left a comment
There was a problem hiding this comment.
Looks great! Only request is relating to the overrides - they give typescript enough context on the return type, depending on the parameters used to call the function. Makes usage a bit more friendly.
tiagosiebler
requested changes
Mar 26, 2025
tiagosiebler
requested changes
Mar 27, 2025
Owner
tiagosiebler
left a comment
tiagosiebler
left a comment
There was a problem hiding this comment.
Tiny nitpicks, looks great otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated a lot of outdated types for request/response for all clients to match the latest changes.